Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: desktop 1.7.3 #7321

Merged
merged 3 commits into from
Aug 18, 2023
Merged

release: desktop 1.7.3 #7321

merged 3 commits into from
Aug 18, 2023

Conversation

begonaalvarezd
Copy link
Member

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

begonaalvarezd and others added 3 commits August 3, 2023 12:37
* chore: upgrade dependencies

* Update migrate_stronghold_snapshot_v2_to_v3

* feat: apply bindings updates

* fix: add missing actor destroy

* chore: update walletrs

* fix: bindings migration error regex

* chore: update bindings to latest commit hash in firefly-desktop branch

* chore: update bindings to latest commit hash in firefly-desktop branch

* fix: macos build (#7303)

* chore: fix building dmg on macos

* fix: macos ci build

* test: try python2 command for python 2.x

* fix: error string

---------

Co-authored-by: Thibault Martinez <[email protected]>
Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brancoder brancoder merged commit 81bc759 into main Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants